-
Notifications
You must be signed in to change notification settings - Fork 440
[WiP] Disable weak xmlsec algorithms #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…rofile for Federation Interoperability
86da651
to
4f8a4f3
Compare
Digest and signing are different operations. We should not mix them together. This should be configured separately for the two. |
The metadata is just declaring something. We should prohibit actually using the algos when they are going to be used to sign docs or create digests. |
I understand but they are xmlsec's algs, so we could handle them in a unique parameter. This will simplify user's approach.. but somethings sounds to me that this solution won't like to you :)
I agree and this is just a basic implementation to start from. I saw how xmlsec is used in pysaml and I think that it would be better to handle this new born parameter together with the upcoming (?) xmlsec-handler refactor. Have you already choose a xmlsec API handler? This would be the point to start from, coupling in it this PR |
I'd also put some reference here as personal notes:
Also: |
pyXMLsecurity is an alternative to xmlsec1, just need to have an example https://github.com/IdentityPython/pyXMLSecurity it only have signing features and no crypto: |
This PR aims to implement a blacklist parameter for xml algs, as discussed here:
Confguration parameter can be declared as follow:
All Submissions: